Optimize alert and pool health selectors#994
Open
copp1723 wants to merge 1 commit into
Open
Conversation
|
Per our AI policy we require all communication to be exclusively human written. Until this requirement is met, we can't spare the effort to review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createSelectorsouseAlerts()returns the same array while alert state is unchanged.MoneroPoolHealthBoxinto primitive selectors instead of returning a new wrapper object fromuseAppSelector.Why
This targets the UI performance bounty in #727.
The previous
useAlerts()selector filtered insideuseAppSelector, allocating a new array on every Redux store update.MoneroPoolHealthBoxalso returned a fresh object from its selector on every update. Both patterns can make React-Redux treat unrelated store changes as changed selector output and re-render subscribers unnecessarily.Testing
eslint src/store/hooks.ts src/store/selectors.ts src/renderer/components/pages/help/MoneroPoolHealthBox.tsxgit diff --checkNotes:
yarn tscis blocked in this local clone becausesrc/models/tauriModel.tsis generated and gitignored. The repo README says to generate it withtypeshare+dprint; this machine does not currently havecargo,typeshare, ordprintinstalled.